kalico

Hm, I wrote a reply to this, but I guess I never posted it. :\

The URL in my previous post (private) demonstrates the problem. It had the wrong template applied when you last looked at it, but I’ve fixed that. You can now see 3 downloads in the package.

I just re-uploaded those files today, and tested again. I now get 3 blank documents. They do go through the process of downloading (so the error message is gone) but the files are empty.

Thanks for checking into it. 🙂

Wow, thank you Shaon. I would have spent ages trying to track that down. Whatever you did…will I have to re-do it when the plugin is updated, or is it in the child theme’s function.php, or ?? I just want to be sure I don’t lose it track of it.

Thanks so much, Shaon! There is just one more thing….there is one odd change in the appearance. If you look at any of the popup modals, they now have two border lines — the lower one used to be at the bottom of the modal content, but now it is going right through the content. It would seem to be accounted for by the 15px of padding given for .modal-body. I don’t have any custom CSS affecting those lines (at least, not intentionally) so I wonder if you can take a look?

My only custom CSS for this is as follows:

.w3eden .col-md-9 {
  text-align: left;
  overflow: auto;
  max-height: 400px;
}

.w3eden .modal-title {
  font-weight: bold;
}

#wpdm-popup-link .modal-dialog { 
   max-width: 95%; overflow: auto; 
}

Thanks again…

Hi all,

I know you’ve been working hard on the updates to the plugin. I just wanted to update this to let you know that, unfortunately, the issues with the popup shortcode in templates has not been fixed yet.

I deleted and reinstalled WPDM, so I have 4.5.2 (the autoupdate is not working for me) in hopes that the problem was fixed. Of course, that removed the manual fix I had done earlier (to add back in the DownloadPageContent function back into wpdm-core.php). But the problem with the 500 error is back now.

I hope you can include this in an update soon.

Ok, this is definitely looking like something with WPDM that broke on the update I did yesterday.

Got the php error log and here’s what it says:

PHP Fatal error: Call to undefined function DownloadPageContent() in /var/www/html/wp-content/plugins/wpdm-extended-shortcodes/wpdm-extended-shortcodes.php on line 528, referer: http://members.nrocnetwork.org/resources/test-popups/

Can you help? Thx

Yup, we discovered the same thing. The strange thing is….that theme file does not exist, there isn’t even a /images subdir. And I haven’t updated the theme recently….certainly not in the time it took to break (between yesterday morning and yesterday afternoon).

And you are certain this call did not come from anything in WPDM code?

Because the only thing I did yesterday that seems relevant is update some plugins (which have since been disabled for troubleshooting) and update WPDM and its associated plugins.

Could this be related? I updated WPDM today. I updated the whole plugin first, and now it has the automatic updates option (yay!). I got my login working (took a couple tries, not sure why) then tried to update the two add-ons (tinymce and image button) with the automated option, and it says “success” — but it’s not really updating anything.

I can’t tell if something in there is the “cause” or if that’s just the “effect” of this 500 error.

I restarted apache on my server, but that did not help.

Wondering if I should manually update the two add-ons, then try again?

UPDATE: I disabled then deleted the two add-ons, then installed them from the new interface. They work fine, no problems. 500 error still exists. 😛

Thanks, Shahriar. That helped (why didn’t I think of % earlier?)….although I’m still having a little trouble with making sure the “close” button doesn’t vanish. This might be the drawback of my approach, as mentioned above. I tried working with max-height, and tried adding overflow: auto;. But it doesn’t provide scroll bars to the whole modal, as I had hoped it might. I’m still fiddling around with it; might come up with something else….might have to circle back to this later, because this isn’t the most pressing issue I have with the site at the moment. 🙂

Thanks for all your assistance.

Thanks, Shaon. Prior to getting your response, I came up with the following solution (based on what I could see with dev tools):

.w3eden .col-md-9 {
  text-align: left;
  overflow: auto;
  max-height: 500px;
}

This seems to work in my case — at least with the particular page template I created for this purpose, which has two columns.

600px was a bit too much for smaller screens like my laptop, so I went with 500px.

I added the left text alignment since many of our descriptions include formatting, such as lists, which look funny centered.

I don’t know if there are any particular drawbacks to what I did (if so, please tell me!), but the biggest difference I noticed was that with your version, the entire content of the modal scrolls, and with mine, only the package description scrolls. Again, this is because of my template — my CSS targets the column which contains only the description, leaving the image and download link stationary.

I’m just hoping this doesn’t break something else….so if you see any drawbacks to my approach please let me know.

Thanks!

Unfortunately, that did not solve the problem. I selected a PDF file to test with, set to public access (anyone with the link can view) and then added to my package. When I click the download link, I still get ERR_CONTENT_LENGTH_MISMATCH.

I think we are both editing the template…perhaps we should stop before we create a monster. 😉