Matthew Swift

Forum Replies Created

Viewing 13 posts - 1 through 13 (of 13 total)
Nov 22, 2017 at 9:49 pm
#65948
Member
Matthew Swift
OP
This reply has been marked as private.
Oct 3, 2017 at 3:19 pm
#64023
Member
Matthew Swift
OP

Did you receive my previous post, which identifies the code which causes the problem? Is correcting this issue now on the list for a future update?

Sep 22, 2017 at 3:09 pm
#63396
Member
Matthew Swift
OP
This reply has been marked as private.
Sep 22, 2017 at 2:04 pm
#63392
Member
Matthew Swift
OP

I notice there is also parallel documentation of the template variables within the WP-admin interface which should be updated in parallel (and that the documentation there is missing mention of file_list_extended and other template variables).

Sep 22, 2017 at 1:52 pm
#63391
Member
Matthew Swift
OP

I made multiple changes to substitute the built-in “author” role in place of the “WPDM-tester” role. Same results: correct in all cases except the wpdm_category shortcode case.

I remind you that the plugin can and does handle permissions properly (including “custom” roles) in other circumstances, just not within the wpdm_category shortcode. Individual package pages, WordPress pages containing wpdm_package shortcodes, and the static category archive page all work fine. Either the wpdm_category shortcode is not using the same code base as the other three to check the user’s access to a package, or it is providing the wrong parameters/context to the shared subroutine. Instrumenting the permissions check code seems like the way to go if you ask me, to see what’s going wrong.

Sep 21, 2017 at 4:53 pm
#63240
Member
Matthew Swift
OP

I tested my system just now with just two plugins active: download manager, and “Coming Soon Page & Maintenance Mode by SeedProd” which was needed to keep the site private during testing. Same problem with the shortcode page: just two of the four packages visible.

Sep 21, 2017 at 3:56 pm
#63231
Member
Matthew Swift
OP

Therefore please add to the documentation of [file_list] (and also presumably for [file_list_extended]) at https://www.wpdownloadmanager.com/doc/templates/template-tags/ a statement such as:

for performance reasons, this shortcode is disabled in the category page [or “archive page” as you put it above]

It would also be helpful, instead of simply disabling the shortcode so that it passes through un-interpreted, which will always look to the user like a bug, to substitute a different subroutine which simply prints the message “file_list shortcode is disabled for performance reasons”.

It would also be nice if this performance decision could be over-ridden by the administrator in Settings for cases where the performance hit is irrelevant. The fact that the default is disabled “for performance reasons” alerts user to potential performance issues when scaling up the use of it.

Sep 21, 2017 at 3:45 pm
#63229
Member
Matthew Swift
OP

The user “demo” has only one role: the role “demo.” (I can’t inspect directly but deduced this by changing permissions on new package https://demo.wpdownloadmanager.com/wpdmpro/download/ms-package/).

Please add a second role such as the default “subscriber” role to the user “demo,” then let’s see if it still works.

I can’t log on to the demo site with my forum credentials, and the user “demo” doesn’t let me create a user and assign roles.

Sep 19, 2017 at 10:06 pm
#63107
Member
Matthew Swift
OP

The contents of the shortcode page, which is the page with the problem is:

[wpdm_category id="wpdm-package-category" cols="1" toolbar="1"]

Value of template= does not change results, only packages 2 and 4 are visible.

Sep 19, 2017 at 9:59 pm
#63106
Member
Matthew Swift
OP

One minor correction: when I wrote

Allow Access: blank [default]

That is incorrect, the default is “+All Visitors.” The value of “Allow Access” for Test Package 1 is blank, i.e. no explicit permissions, not the default permissions.

Sep 19, 2017 at 9:55 pm
#63103
Member
Matthew Swift
OP
This reply has been marked as private.
Sep 19, 2017 at 11:50 am
#63076
Member
Matthew Swift
OP

Sorry for the delay I thought I would automatically be subscribed to my own posts but I was not. My site has sensitive data and I will send the private message after I have set up a separate area for you which reproduces the problem. Meanwhile, I have described the problem very carefully. Are you unable to reproduce it on your system? What further questions do you have that I can answer?

Sep 19, 2017 at 11:49 am
#63075
Member
Matthew Swift
OP

Sorry for the delay I thought I would automatically be subscribed to my own posts but I was not. My site has sensitive data and I will send the private message after I have set up a separate area for you which reproduces the problem. Meanwhile, I have described the problem very carefully. Are you unable to reproduce it on your system? What further questions do you have that I can answer?

Viewing 13 posts - 1 through 13 (of 13 total)