Forum Replies Created
Hello,
Could you please update me on whether or not you are going to fix these many bugs in your download routine. Or are bugs in the free version OK, because people should buy the pro version? If that’s the case, please at least say so, so that I can go to my customers with this information, rather than constantly having to patch your buggy code.
Sorry to be impatient, bug this has been going on for over a year now.
Ron
Hi, could you please give a status update on this issue? One more, I have already provided a detailed analysis of the problems, and provided some fixes. I still have them, if you need them. It’s been a long time… you can also write my privately, just let me know if there’s any chance of really fixing this.
Best Regards,
Ron
Another thing, as an example. About line 140, you simply ignore the end-point of the HTTP-RANGE. This really screws with Safari, which first requests only bytes 0-1 and waits for the response, which has to include (along with the single byte as payload) a header that tells it how big the file is, and only then issues a separate request to really get the data. You can see something is wrong with the code simply by looking and seeing the second half of the HTTP-RANGE is ignored.
Thank you again for looking into this!!
Best Regards,
Ron
Sorry, I am not a pro-user. I thought this was a forum for the free version.
And it’s not a feature request, it’s a bug report. It has nothing to do with caching or other plugins.
You wrote that the audio and video players are included in the free version. Is this correct? I assume this means also that WPDM should be able to correctly serve content to the player. Currently, it does not. Can you please check the code snippet I wrote above? It’s pretty clear and such an easy fix that brings so much more to your already impressive product.
Ron
Hi Tanvir,
Thanks for your reply. I really do appreciate you looking into this!
The problem is not in audioplayer, the problem is in the headers associated with the download.
There’s a really good example in line 120 of FileSystem.php. The clause
(isset($extras[‘play’]) && strpos($_SERVER[‘HTTP_USER_AGENT’], “Safari”))
wants to check if the user has clicked the audioplayer button and if the browser can accept the streaming (HTTP 206) code. The problem is, what do you do when these conditions are met? You choose *not* to stream, but to return the file directly. This clause needs to be inverted!
There are some other problems. I will send them to you if you want, but, like I said, I think your dev team has already fixed this in the pro version, and it just needs to be transported over to the free version. If that is wrong, I am more than happy to provide other fixes.
Thanks again for your support!!
Ron
Thanks for checking this!
Yes, this is working for me, too. I mentioned the site not working in an earlier post, so something has changed. I looked at the headers, they are correct. Could it be this is fixed in the pro version, but not in the free version? Or maybe that the wordpress plugin directory has not been updated?
The problem is in the file __/FileSystem.php, can you check that these are the same.
Thanks again for your help!!!
Best Regards,
Ron
No, I haven’t at least not recently or in any sort of constructive way. I have been posting on this topic, even offering fixes, for over a year. Somehow, the threads have been deleted.
If Download Manager wasn’t otherwise so great, if it didn’t meet so many needs and meet them better than its competition, it wouldn’t be so frustrating. Or if the problems weren’t so obvious, if you would just look at the code (and maybe have a bit of knowledge of the standards). It would literally take under an hour to fix. Obviously you have to build, test etc…I know every change takes effort. But this is the download function in a product called download manager… in a year, there should be time to fix this.
Again, I think on the whole the product is the best out there. If a little frustration comes though in my posts, I am sorry. Please feel free to contact me for technical details.
By the way, the latest thread on this issue is here: https://www.wpdownloadmanager.com/support/topic/audio-player-progress-bar-not-working-rewind-fast-forward-3/
Hello Jean,
There is a bug in Download Manager, namely, when streaming media the headers are very very wrong. The development team never fixed this in over a year, so I did an analysis myself, found the bugs and fixed them. I’ve shared the analysis and fixes with the development team, who, unfortunately, still haven’t acted on them.
The problem is pretty localized in one function in one file (really, just a few lines of code), so what I’ve been doing (since it would be even more painful to transfer my customers files to a system with more support), is apply the patch every time I update. If you would like, I could share the patch with you.
Best Regards,
Ron
Hi, could you please give a status update on this issue? One more, I have already provided a detailed analysis of the problems, and provided some fixes. I still have them, if you need them. It’s been a long time… you can also write my privately, just let me know if there’s any chance of really fixing this.
Best Regards,
Ron
Any word on when this will be fixed in the free version as well? It’s over a month since the problem in the code was identified.
This looks like https://www.wpdownloadmanager.com/support/topic/modal-login-hangs/ to me. It can be fixed by changing one line of code (see my entry from Sept. 5).
Resolved in 3.2.16!
Sorry, I cannot do that. However, I am happy to beta-test, if you send me the ZIP file.
Sorry, you hardly give the impression of being so competent that I would feel comfortable giving you admin rights to one of my systems.
Please instead concentrate on fixing some of the bugs I have reported, for which, as with this bug, I have even provided the lines of code that need to be corrected.
It’s no problem to wait, but I was specifically asked to download and test. Which I did, from two locations. This also took time, my time. It’s not like I was the one that was not sparing you additional time. It’s more like your team is the one wasting my time.
But I’m extremely happy if these problems are being resolved and not being asked to “solve them on my side”
This is the second time you have asked this in this thread, and my answer is the same. I think there is a bug in the code, the PHP is inconsistent with the JS. I do not think it’s a configuration problem.
I have some questions for you:
Have you looked at the files and lines I listed in my post from September 5? Are you saying that there is no problem there? Can you maybe tell me what should be setting wpdm_asset.spinner? Do you have a demo where I can see the modal login working in a version later than 3.12?
It’s really unfortunate that someone hijacked this thread, and gave it the illusion of progress being made. If I am correct in my analysis, this is something that is fixed by changing one line of code, and so it’s a bit frustrating that we are again at the “solve it on your side” stage. So I need to know if you’ve looked at the code and can confirm that the problem is on my side.
I guess I’m not sure where I’m supposed to download from. I tried the WordPressPlugin Directory and the free download from your site, and can’t see any differences. Please send me the link.
Hey, that is great news! I will be testing this today and report back or resolve the issue.
Now that Tom’s problem has been solved, we can hopefully return to the original topic of this thread: the modal login hangs because (I guess) in the file “modal-login-form.php” the name “wpdm_asset” should have been changed to “wpdm_js”. This is a one line fix, but it has prevented my from updating since 3.2.12.
Please read the thread before “answering”. I do not have a page that demonstrates the problem. I have found a workaround, because I have a system to keep running, and, like I said, your dev team is not responsive. I have several threads where I even give lines that need to be changed, and I don’t get any sort of reasonable response from you. Not even “we see the problem and it will be fixed in the next release”. Bug reports are simply ignored, or, as here, you talk in circles.
The problems in downloadFile, and the problems with the modal login are more important to me, but this is also the sort of bug that if you had any pride in your product you would want to fix.
Please forgive my frustration, but this has been going on for months. Do you really not care?
I just want to note that this bug is still not fixed, although the buggy code has moved to the file all-packages-shortcode.php.
Usually, when a user makes the effort, rather than just reporting a bug, to find actually find the problem in the code, and include even the lines that need to be looked at, he can expect the problem to be resolved quickly. At least a technical response, maybe it’s not a bug, but a feature. In this case, the report is three months old and I’ve really heard nothing. I have a work around for this bug, but I’d rather not have workarounds on my side.
Hi Nayeem,
I have no idea how to solve this problem “on my side”. It seems to me, there is a bug in your codebase. In the file I mentioned above, the lines
} else {
$(‘#wpdmloginmodal-submit’).html(wpdm_asset.spinner+” “+res.message);
location.href = __lm_redirect_to;
}
But wpdm_asset is nowhere else in your codebase. I think you want to set it in download-manager.php about line 482.
$wpdm_js = array(
‘spinner’ ► ‘<i class=”fas fa-sun fa-spin”></i>’
);
$wpdm_js = apply_filters(“wpdm_js_vars”, $wpdm_js);
wp_localize_script(‘wpdm-frontjs’, ‘wpdm_url’, $this->wpdm_urls);
wp_localize_script(‘wpdm-frontjs’, ‘wpdm_js’, $wpdm_js);
I think here you use the name “wpdm_js” where in the other code you use “wpdm_asset”.
I think all you need to do is change the wpdm_asset in modal_login_form to wpdm_js. I hope this helps to resolve this issue.
Best Regards,
Ron
Hello again,
I checked my console: it seems the problem is the variable wpdm_asset in the file src/User/Views/modal-login-form.php, on line 115. It’s not defined anywhere. And even searching your codebase I don’t see the code that should define it.
Hope that helps to finally resolve this issue!
Ron