[Download Manager v 2.7.0] Errors in JS and CSS

in Download Manager Pro Feature Request

Viewing 1 post (of 1 total)
Nov 7, 2014 at 11:11 am
#22269
Member
fab120
OP

JS
You shouldn’t use jquery functions that are deprecated or removed.

In front.js (line 1)

jQuery(function ($) {
    $('.wpdm-download-locked.pop-over').live('click',function () {

live() is deprecated in jQuery v1.7 and removed in jQuery 1.9

.live()

You should use delegate() (added in jQuery 1.4.2)

.delegate()


(but that isn’t also a good choice…. It’s better on(), but it won’t bind events to elements that are added subsequently to the DOM)

CSS
You shouldn’t use for plugins very generic classes like .green and .blue.
If someone use that classes for example for change the font color, you will break that.

In front.css (line 844)

green .ptitle a,.blue .ptitle a,.coffee .ptitle a,.xmas .ptitle a,.red .ptitle a,.lightblue .ptitle a,
.green,.blue,.coffee,.xmas,.red,.lightblue,
.green > a,.blue > a,.coffee > a,.xmas > a,.red > a,.lightblue > a {...}

.green {...}
.green:hover{...}
.blue {...}
...
Viewing 1 post (of 1 total)

The topic "[Download Manager v 2.7.0] Errors in JS and CSS" is closed to new replies.