Pagination not working if page has query string

Viewing 24 posts - 1 through 24 (of 24 total)
#154938

Ron Barack
Participant

If a page has a query string (other than “s”??) the generated links are not correct. They will be of the form

https://example.com/mypage?myqs=val/page/2/

where they should be

https://example.com/mypage/page/2/?myqs=val

Not sure why “s” is specially handled…

Please review wpdm-all-downloads.php lines 402 – 410

#154941

Humayon
Spectator

Hello @otrok,
Please share your related page/file/package URL and WordPress admin login credentials with us in a private reply so that we can debug and give you a better solution about it?
thanks

#154968

Ron Barack
Participant

I can work around the bug using the paginate_links filter. I was actually just logging the bug, assuming you would be interested in fixing it. For that, the description I gave should be more than enough. But I’m assuming you are interested in fixing bug. I also suggested the fix for the bug I described in: https://www.wpdownloadmanager.com/support/topic/audio-player-progress-bar-not-working-rewind-fast-forward-2/ but you haven’t taken any action there, either.

#154981

Shahjada
Keymaster
This reply has been marked as private.
#155228

Ron Barack
Participant
This reply has been marked as private.
#155301

Shahjada
Keymaster

I’m not seeing any pagination at all there.

#155304

Ron Barack
Participant

The link you asked about was from the other bug report, the one about audio previews not processing jumps, fast-forwards or rewinds properly. I don’t have a demo of the pagination bug because, as I wrote above, I have a work-around and frankly, your team is extremely slow to fix things, even when I provide the lines of code that need to be altered. You are obviously not a technical person, but, believe me, any programmer looking at the bug description and the lines of code I pointed out would be be to see the problem and fix it in a few minutes. Please pass it on to your developers, I know you have some good people there.

I will send the link to the page with pagination working properly privately.

As for the audio player bug, I provided a preliminary analysis, but it obviously requires a bit more work to fix.

#155305

Ron Barack
Participant
This reply has been marked as private.
#161016

Ron Barack
Participant

I just want to note that this bug is still not fixed, although the buggy code has moved to the file all-packages-shortcode.php.

Usually, when a user makes the effort, rather than just reporting a bug, to find actually find the problem in the code, and include even the lines that need to be looked at, he can expect the problem to be resolved quickly. At least a technical response, maybe it’s not a bug, but a feature. In this case, the report is three months old and I’ve really heard nothing. I have a work around for this bug, but I’d rather not have workarounds on my side.

#161019

Humayon
Spectator

Hi @otrok,
The admin URL is not working. Please check this.
Can you please let us know what is the valid admin URL?
Thanks.

#161041

Ron Barack
Participant

Please read the thread before “answering”. I do not have a page that demonstrates the problem. I have found a workaround, because I have a system to keep running, and, like I said, your dev team is not responsive. I have several threads where I even give lines that need to be changed, and I don’t get any sort of reasonable response from you. Not even “we see the problem and it will be fixed in the next release”. Bug reports are simply ignored, or, as here, you talk in circles.

The problems in downloadFile, and the problems with the modal login are more important to me, but this is also the sort of bug that if you had any pride in your product you would want to fix.

Please forgive my frustration, but this has been going on for months. Do you really not care?

#161051

Shahjada
Keymaster

Hi,
Sorry for your inconvenience. Our dev team is working on the download function. However, I’ve adjusted the pagination issue now and reuploaded the updated zip ( didn’t change the version number yet ). Please download again and update your copy.

#161097

Ron Barack
Participant

Hey, that is great news! I will be testing this today and report back or resolve the issue.

#161098

Humayon
Spectator

Hello @otrok,
yes, please test and then let us know about it.
Thank You

#161127

Ron Barack
Participant

I guess I’m not sure where I’m supposed to download from. I tried the WordPressPlugin Directory and the free download from your site, and can’t see any differences. Please send me the link.

#161175

Humayon
Spectator

Hi @otrok,
The free update will be available within this week. So, please spare us some additional time.
Thank You for your patience and cooperation.
Regards

#161351

Ron Barack
Participant

It’s no problem to wait, but I was specifically asked to download and test. Which I did, from two locations. This also took time, my time. It’s not like I was the one that was not sparing you additional time. It’s more like your team is the one wasting my time.

But I’m extremely happy if these problems are being resolved and not being asked to “solve them on my side”

#161362

Shahjada
Keymaster

Hi,
Sorry, I thought you were a pro user. However, the new update is coming on the next Monday. However, if you want to get it resolved immediately, please send temporary wp-admin login info in a private reply, we shall update it on your site.

#162019

Ron Barack
Participant

Sorry, you hardly give the impression of being so competent that I would feel comfortable giving you admin rights to one of my systems.

Please instead concentrate on fixing some of the bugs I have reported, for which, as with this bug, I have even provided the lines of code that need to be corrected.

#162248

Humayon
Spectator

Hello,
The update will be released ASAP.
However, for a quicker resolution please cooperate with us by providing your admin login credentials in a private reply.
Thank You

#162285

Ron Barack
Participant

Sorry, I cannot do that. However, I am happy to beta-test, if you send me the ZIP file.

#162296

Humayon
Spectator

Hi @otrok,
Sure, we will let you know about it.
Thanks.

#162331

Ron Barack
Participant

Resolved in 3.2.16!

#162332

Humayon
Spectator

Hello @otrok,
Glad to hear that.
Thank you for your cooperation.
With Regards

Viewing 24 posts - 1 through 24 (of 24 total)

The topic ‘Pagination not working if page has query string’ is closed to new replies.