Audio Player broken in 3.2.12

Hello Jean,

There is a bug in Download Manager, namely, when streaming media the headers are very very wrong. The development team never fixed this in over a year, so I did an analysis myself, found the bugs and fixed them. I’ve shared the analysis and fixes with the development team, who, unfortunately, still haven’t acted on them.

The problem is pretty localized in one function in one file (really, just a few lines of code), so what I’ve been doing (since it would be even more painful to transfer my customers files to a system with more support), is apply the patch every time I update. If you would like, I could share the patch with you.

Best Regards,
Ron

No, I haven’t at least not recently or in any sort of constructive way. I have been posting on this topic, even offering fixes, for over a year. Somehow, the threads have been deleted.

If Download Manager wasn’t otherwise so great, if it didn’t meet so many needs and meet them better than its competition, it wouldn’t be so frustrating. Or if the problems weren’t so obvious, if you would just look at the code (and maybe have a bit of knowledge of the standards). It would literally take under an hour to fix. Obviously you have to build, test etc…I know every change takes effort. But this is the download function in a product called download manager… in a year, there should be time to fix this.

Again, I think on the whole the product is the best out there. If a little frustration comes though in my posts, I am sorry. Please feel free to contact me for technical details.

Thanks for checking this!

Yes, this is working for me, too. I mentioned the site not working in an earlier post, so something has changed. I looked at the headers, they are correct. Could it be this is fixed in the pro version, but not in the free version? Or maybe that the wordpress plugin directory has not been updated?

The problem is in the file __/FileSystem.php, can you check that these are the same.

Thanks again for your help!!!

Best Regards,
Ron

Hi Tanvir,

Thanks for your reply. I really do appreciate you looking into this!

The problem is not in audioplayer, the problem is in the headers associated with the download.

There’s a really good example in line 120 of FileSystem.php. The clause

(isset($extras[‘play’]) && strpos($_SERVER[‘HTTP_USER_AGENT’], “Safari”))

wants to check if the user has clicked the audioplayer button and if the browser can accept the streaming (HTTP 206) code. The problem is, what do you do when these conditions are met? You choose *not* to stream, but to return the file directly. This clause needs to be inverted!

There are some other problems. I will send them to you if you want, but, like I said, I think your dev team has already fixed this in the pro version, and it just needs to be transported over to the free version. If that is wrong, I am more than happy to provide other fixes.

Thanks again for your support!!

Ron

• This reply was modified 2 years, 9 months ago by Ron Barack. Reason: typo

Sorry, I am not a pro-user. I thought this was a forum for the free version.

And it’s not a feature request, it’s a bug report. It has nothing to do with caching or other plugins.

You wrote that the audio and video players are included in the free version. Is this correct? I assume this means also that WPDM should be able to correctly serve content to the player. Currently, it does not. Can you please check the code snippet I wrote above? It’s pretty clear and such an easy fix that brings so much more to your already impressive product.

Ron